tycho-versions-plugin: Support ci-friendly versions #3900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laeubi
reviewed
May 31, 2024
tycho-versions-plugin/src/main/java/org/eclipse/tycho/versions/pom/PomFile.java
Outdated
Show resolved
Hide resolved
laeubi
reviewed
May 31, 2024
tycho-versions-plugin/src/main/java/org/eclipse/tycho/versions/pom/PomFile.java
Outdated
Show resolved
Hide resolved
laeubi
reviewed
May 31, 2024
tycho-versions-plugin/src/main/java/org/eclipse/tycho/versions/pom/PomFile.java
Outdated
Show resolved
Hide resolved
sratz
force-pushed
the
set-version-ci-friendly
branch
from
31fec6c
to
19c4722
Compare
laeubi
reviewed
May 31, 2024
tycho-versions-plugin/src/main/java/org/eclipse/tycho/versions/pom/PomFile.java
Outdated
Show resolved
Hide resolved
In PomFile#getVersion(), resolve properties used in the raw version of the project. This is necessary so that downstream manipulators (MANIFEST.MF, feature.xml, category.xml, ...) can see the actual version and act on it. Fixes eclipse-tycho#3744.
sratz
force-pushed
the
set-version-ci-friendly
branch
from
19c4722
to
1746be2
Compare
|
I refactored things a bit more. In fact, the utility is not specific to versions, but just deals with properties in general. |
laeubi
added
the
backport-to-tycho-4.0.x
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PomFile#getVersion(), resolve properties used in the raw version of the project. This is necessary so that downstream manipulators (MANIFEST.MF, feature.xml, category.xml, ...) can see the actual version and act on it.
Fixes #3744.